Skip to content

Migrate to GitHub Actions reusable workflows#75

Merged
timkimadobe merged 4 commits intoadobe:mainfrom
timkimadobe:reusable-workflows
Jan 31, 2025
Merged

Migrate to GitHub Actions reusable workflows#75
timkimadobe merged 4 commits intoadobe:mainfrom
timkimadobe:reusable-workflows

Conversation

@timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Jan 29, 2025

Description

This PR migrates the repo to use the reusable workflows (tag version: gha-android-3.1.1) from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
    • Has been configured to accommodate different release components as they are added in the future
  • Snapshot
    • Has been configured to accommodate different release components as they are added in the future
  • Build and test
    • Migrating CircleCI -> GitHub Actions
  • Makefile
    • Create alias lint for checkstyle - out of the box workflow expects lint
    • Update notificationbuilder-publish -> notificationbuilder-publish-main to match Core's style, and expected format for workflow

Questions for reviewers

  1. I'm not sure I understand the purpose of using a boolean flag to control whether the snapshot is published—since publishing is the only outcome of running this workflow, wouldn't simply not running it achieve the same result? In the migration, I updated the snapshot workflow to instead be able to choose between variants like the release workflow.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (0d312c7) to head (9b3d4a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #75   +/-   ##
=========================================
  Coverage     92.28%   92.28%           
  Complexity      295      295           
=========================================
  Files            38       38           
  Lines          1893     1893           
  Branches        176      176           
=========================================
  Hits           1747     1747           
  Misses           86       86           
  Partials         60       60           
Flag Coverage Δ
android-functional-tests 0.00% <ø> (?)
android-unit-tests 92.28% <ø> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkimadobe timkimadobe merged commit f660765 into adobe:main Jan 31, 2025
12 of 13 checks passed
@timkimadobe timkimadobe deleted the reusable-workflows branch January 31, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants