This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Add runtime notification permissions for Android 13#32
Open
spoorthipujariadobe wants to merge 2 commits intoadobe:mainfrom
Open
Add runtime notification permissions for Android 13#32spoorthipujariadobe wants to merge 2 commits intoadobe:mainfrom
spoorthipujariadobe wants to merge 2 commits intoadobe:mainfrom
Conversation
rymorale
reviewed
Mar 13, 2023
|
|
||
| private void askNotificationPermission() { | ||
| // This is only necessary for API level >= 33 (TIRAMISU) | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { |
Contributor
There was a problem hiding this comment.
would it make sense to move this check to line 57 instead?
rymorale
approved these changes
Mar 13, 2023
Contributor
rymorale
left a comment
rymorale
left a comment
There was a problem hiding this comment.
just a minor question on the version check but it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding runtime notification permission request for Android version >= 13
Related Issue
Motivation and Context
Required behavior change since API 33 https://developer.android.com/develop/ui/views/notifications/notification-permission
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: