-
Notifications
You must be signed in to change notification settings - Fork 38
Add message.show usage in sample app #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ishita-gambhir-adobe
wants to merge
1
commit into
adobe:staging
Choose a base branch
from
ishita-gambhir-adobe:shouldShowMessage
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,6 @@ import { useRouter } from 'expo-router'; | |
| const SURFACES = ['android-cbe-preview', 'cbe/json', 'android-cc']; | ||
| const SURFACES_WITH_CONTENT_CARDS = ['android-cc']; | ||
|
|
||
|
|
||
| const messagingExtensionVersion = async () => { | ||
| const version = await Messaging.extensionVersion(); | ||
| console.log(`AdobeExperienceSDK: Messaging version: ${version}`); | ||
|
|
@@ -53,8 +52,21 @@ const setMessagingDelegate = () => { | |
| console.log('Result:', result); | ||
| }); | ||
| }, | ||
| shouldShowMessage: () => true, | ||
| shouldSaveMessage: () => true, | ||
| shouldShowMessage: msg => { | ||
| const msgId = msg.id; // use this message id to save the message in the cache | ||
| console.log('msgId', msgId); | ||
|
|
||
| // return true to show the message else return false to suppress the message | ||
| // if you want to save the message in order to show it later, set shouldSaveMessage to true | ||
| return true; | ||
| }, | ||
| shouldSaveMessage: msg => { | ||
| const msgId = msg.id; // use this message id to save the message in the cache | ||
| console.log('msgId', msgId); | ||
|
|
||
| // return true to save the message in the cache else return false to not save the message | ||
| return true; | ||
| }, | ||
| urlLoaded: (url, message) => console.log(url, message), | ||
| }); | ||
| console.log('messaging delegate set'); | ||
|
|
@@ -82,6 +94,13 @@ const getLatestMessage = async () => { | |
| console.log('Latest Message:', message); | ||
| }; | ||
|
|
||
| const showMessage = async () => { | ||
| const messageId = 'MESSAGE_ID'; // replace MESSAGE_ID with the id of the message you want to show | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can have a global variable for saving message id which will save the latest saved message. In case we want to add a specific message I'd we have this comment to provide it here. |
||
| const message = new Message({id: messageId, autoTrack: true}); | ||
| message.show(); | ||
| console.log(`message with id ${messageId} shown`); | ||
| } | ||
|
|
||
| // this method can be used to track click interactions with content cards | ||
| const trackContentCardInteraction = async () => { | ||
| const messages = await Messaging.getPropositionsForSurfaces(SURFACES_WITH_CONTENT_CARDS); | ||
|
|
@@ -159,6 +178,7 @@ function MessagingView() { | |
| /> | ||
| <Button title="getCachedMessages()" onPress={getCachedMessages} /> | ||
| <Button title="getLatestMessage()" onPress={getLatestMessage} /> | ||
| <Button title="showMessage()" onPress={showMessage} /> | ||
| <Button title="trackAction()" onPress={trackAction} /> | ||
| <Button title="trackPropositionInteraction()" onPress={trackContentCardInteraction} /> | ||
| <Button title="trackContentCardDisplay()" onPress={trackContentCardDisplay} /> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have a toggle switch for shouldShow and shouldSave to set the boolean value.