[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates#128
[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates#128siddique-adobe wants to merge 1 commit intoadobe:dev-v3.4.1from
Conversation
bdd3d86 to
08ad7ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.4.0 #128 +/- ##
=================================================
- Coverage 82.95% 52.75% -30.20%
+ Complexity 233 130 -103
=================================================
Files 10 10
Lines 1126 1126
Branches 181 181
=================================================
- Hits 934 594 -340
- Misses 111 446 +335
- Partials 81 86 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
9fb5042 to
c5bb2b2
Compare
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.
Yeah @spoorthipujariadobe we'll merge this PR only when we'll release the major version bump, I already requested for the updates on the same from Praveen. |
c5bb2b2 to
dbbd594
Compare
…nterface 2. Moved the existing tests calls to update and get propositions internal methods 3. Changed signature of of get and update propositions internal from private to package-private and made Visible for testing
dbbd594 to
8715f34
Compare
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: