Skip to content

[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates#128

Open
siddique-adobe wants to merge 1 commit intoadobe:dev-v3.4.1from
siddique-adobe:MOB-22791
Open

[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates#128
siddique-adobe wants to merge 1 commit intoadobe:dev-v3.4.1from
siddique-adobe:MOB-22791

Conversation

@siddique-adobe
Copy link
Contributor

@siddique-adobe siddique-adobe commented Jan 27, 2025

Description

  1. We've marked updateProposition without callback method deprecated in our last release
  2. We'll be removing and merging the same in the upcoming major version release of target

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.75%. Comparing base (8755a28) to head (8715f34).
Report is 13 commits behind head on dev-v3.4.0.

❗ There is a different number of reports uploaded between BASE (8755a28) and HEAD (8715f34). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8755a28) HEAD (8715f34)
android-unit-tests 1 0
Additional details and impacted files
@@                Coverage Diff                @@
##             dev-v3.4.0     #128       +/-   ##
=================================================
- Coverage         82.95%   52.75%   -30.20%     
+ Complexity          233      130      -103     
=================================================
  Files                10       10               
  Lines              1126     1126               
  Branches            181      181               
=================================================
- Hits                934      594      -340     
- Misses              111      446      +335     
- Partials             81       86        +5     
Flag Coverage Δ
android-functional-tests 52.75% <ø> (-0.18%) ⬇️
android-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../com/adobe/marketing/mobile/optimize/Optimize.java 37.10% <ø> (-37.37%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@spoorthipujariadobe spoorthipujariadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.

@siddique-adobe
Copy link
Contributor Author

We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.

Yeah @spoorthipujariadobe we'll merge this PR only when we'll release the major version bump, I already requested for the updates on the same from Praveen.

@siddique-adobe siddique-adobe changed the base branch from dev-v3.2.3 to dev-v3.3.1 February 17, 2025 11:09
@siddique-adobe siddique-adobe changed the base branch from dev-v3.3.1 to dev-v3.4.0 March 11, 2025 10:38
…nterface

 2. Moved the existing tests calls to update and get propositions internal methods
 3. Changed signature of of get and update propositions internal from private to package-private and made Visible for testing
@siddique-adobe siddique-adobe changed the base branch from dev-v3.4.0 to dev-v3.4.1 April 29, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants