Skip to content

Migrate to GitHub Actions reusable workflows#94

Merged
timkimadobe merged 6 commits intoadobe:mainfrom
timkimadobe:reusable-workflows
Feb 1, 2025
Merged

Migrate to GitHub Actions reusable workflows#94
timkimadobe merged 6 commits intoadobe:mainfrom
timkimadobe:reusable-workflows

Conversation

@timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Jan 29, 2025

Description

This PR migrates the repo to use the reusable workflows (tag version: gha-android-3.3.0) from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
  • Snapshot
  • Build and test
    • Migrating CircleCI -> GitHub Actions
  • Makefile - create alias lint for checkstyle
    • Out of the box workflow expects lint

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (bde7dee) to head (0a40b8f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #94      +/-   ##
============================================
+ Coverage     88.26%   90.56%   +2.29%     
- Complexity      316      324       +8     
============================================
  Files            15       15              
  Lines          1526     1590      +64     
  Branches        182      182              
============================================
+ Hits           1347     1440      +93     
+ Misses          108       82      -26     
+ Partials         71       68       -3     
Flag Coverage Δ
android-functional-tests 35.66% <ø> (?)
android-unit-tests 90.56% <ø> (?)
unit-functional-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkimadobe timkimadobe requested a review from cacheung January 31, 2025 23:00
@timkimadobe timkimadobe merged commit 3a9bde9 into adobe:main Feb 1, 2025
12 of 13 checks passed
@timkimadobe timkimadobe deleted the reusable-workflows branch February 1, 2025 01:09
@timkimadobe timkimadobe mentioned this pull request Feb 1, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants