[Update] PR Template to add design example#1
Open
aditikum wants to merge 2 commits intotracking_masterfrom
Open
[Update] PR Template to add design example#1aditikum wants to merge 2 commits intotracking_masterfrom
aditikum wants to merge 2 commits intotracking_masterfrom
Conversation
cohensus
reviewed
Nov 14, 2023
cohensus
left a comment
There was a problem hiding this comment.
all new features may not have an entire design example. Maybe you want to say:
- All new features must have a corresponding working example of how to use the feature. Add link to example here (can be new or existing):
updating comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding section to PR Template requiring all new features to also have a link to the design example.
This will help document new features for both internal and external contributions.
Collateral (docs, reports, design examples, case IDs):
Tests added:
N/A
Tests run:
N/A