Skip to content

Documentation template for class SimpleFieldSim3D#66

Open
Daniel-Tojal wants to merge 14 commits intoadhusch:developfrom
Daniel-Tojal:docs-classes-FieldSim
Open

Documentation template for class SimpleFieldSim3D#66
Daniel-Tojal wants to merge 14 commits intoadhusch:developfrom
Daniel-Tojal:docs-classes-FieldSim

Conversation

@Daniel-Tojal
Copy link
Contributor

No description provided.

@Daniel-Tojal Daniel-Tojal changed the base branch from master to develop May 25, 2019 10:37
@Daniel-Tojal Daniel-Tojal changed the title Documentation tempa Documentation template for class SimpleFieldSim3D May 25, 2019
%
% Returns:
%
% graphicsHandle:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhusch , Could you please provide a description of the graphicsHandle? Also could you check if the existing descriptions are correct?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally dont like this:

impedance = 800; % Resistance given in [Ohm]
voltage = 1.0; % Voltage given in [V]

When a variable name is completly descriptive the additional comment of exactly the same is redundant noise. I would leave it as

impedance = 800; %[Ohm]
voltage = 1.0; %[V]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks, i'll keep this in mind for future PRs

Copy link
Owner

@adhusch adhusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments from last month. Thx.

%
% Returns:
%
% graphicsHandle:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally dont like this:

impedance = 800; % Resistance given in [Ohm]
voltage = 1.0; % Voltage given in [V]

When a variable name is completly descriptive the additional comment of exactly the same is redundant noise. I would leave it as

impedance = 800; %[Ohm]
voltage = 1.0; %[V]


methods
function this = SimpleFieldSim3D(trajectoryObject)
% Function that serves to initialize a normalized sphere
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the constructor.

%
% Parameters:
%
% impedance: Resistance of the electrodes.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impedance: assumed electrical impedance of the tissue

% Parameters:
%
% impedance: Resistance of the electrodes.
% voltage: Voltage between the electrodes.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voltage: monopolar stimulation voltage

% Parameters:
%
% this: Self-Reference
% ax:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhusch Could you please provide a description for ax and graphicsHandle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants