Skip to content

Additional Metrics for Daily Milk Production Averages #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArjanRovecom wants to merge 4 commits into
base: Develop
Choose a base branch
from
Open

Additional Metrics for Daily Milk Production Averages #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fb344b
Additional Metrics for Daily Milk Production Averages
ArjanRovecom Jun 21, 2023
4118af3
Additional Metrics for Daily Milk Production Averages - downcase firs…
ArjanRovecom Jun 21, 2023
1e569bb
Additional Metrics for Daily Milk Production Averages - remove blank …
ArjanRovecom Jun 21, 2023
ac7a0e0
Add milkingsEntitled
ArjanRovecom Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions resources/icarDailyMilkingAveragesResource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,20 @@
"milkYieldAvg7days": {
"$ref": "../types/icarTraitAmountType.json",
"description": "The average-amount of milk produced within 7 days."
},
"milkRefusals": {
"type": "number",
"description": "Total amount of refusals this day."
},
"milkingsEntitled": {
"type": "number",
"description": "The entitled amount of milkings for this day."
},
"milkCharacteristics": {
"type": "array",
"items": {
"$ref": "../types/icarMilkCharacteristicsType.json"
}
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions resources/icarLactationResource.json
View file
Open in desktop
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gestationDays --> current days in gestation this day --> is it on the last test day or on the date the request for data is sent? I would presume the gestation days on the last test day?

Copy link
Author

@ArjanRovecom ArjanRovecom Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date the request for data is sent. Because we expect that this data can also be provided from for example milking robots on a daily basis, we now assumed the data could be retrieved on the date the request for data is sent. Please let us know if this is a wrong assumption.

Copy link
Collaborator

@cookeac cookeac Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArjanRovecom we discussed this at the ADE technical group meeting on 29 June 2023, and considered that:

  • We would need a date in the data to know what date the gestationDays related to.
  • We recommend that the icarGestationResource should be used for gestation data (but it may still be a good idea to add gestationDays and a date to this resource.

Copy link
Collaborator

@cookeac cookeac Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArjanRovecom you would be welcome at our next ADE technical group meeting to help discuss this. It is at 08:15 CEST on 13 July 2023. Message me directly if you would like a Teams invite link.

Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@
},
"milkRecordingMethod": {
"$ref": "../types/icarMilkRecordingMethodType.json"
},
"gestationDays": {
"type": "number",
"description": "Current days in gestation this day."
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions types/icarConsumedFeedType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
"feedConsumption": {
"$ref": "../types/icarFeedQuantityType.json",
"description": "The amount of feed the animal has consumed"
},
"feedResidues": {
"$ref": "../types/icarFeedQuantityType.json",
"description": "Amount of feed that is not consumed or leftover during milking."
}
}
}