Skip to content

Conversation

@Gjum
Copy link
Contributor

@Gjum Gjum commented Nov 15, 2025

No description provided.

@adepierre
Copy link
Owner

Thanks for the PR. Could you detail what does it fix exactly and in which case so I can check everything works properly? More importantly, could you confirm it doesn't break anything on vanilla ? Cause it's not the first "chat parsing fix" PR in this repo and the previous one broke the parsing on vanilla in favor of some modded servers.

@Gjum
Copy link
Contributor Author

Gjum commented Nov 15, 2025

The previous implementation completely ignored extra if it was a list of plain strings not wrapped in a compound. The changes only handle this additional case and do not impact any chat that was previously working fine.

Example that worked before and still works: {text:"Hello", extra:[{text:" World"}, {text:"!"}]}

Example that did not work before but will work now: {text:"Hello", extra:[" World","!"]}

Could you please link that previous PR? I was not able to find it. Found it: #72

@adepierre
Copy link
Owner

You can find some previous PR messing up with the parsing in #38 and #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants