Skip to content

Conversation

@hanggrian
Copy link

Description

  • Configure 80-character max length in EditorConfig.

    This configuration is preferred by Google Shell Style Guide. Also enforces 2-space indentation already specified globally.

  • Add .shellcheckrc to suppress source commands.

    ShellCheck is installed globally (or as a plugin in an IDE). Enable external sources to find the activation script in a virtual environment directory.

  • Remove flags and default value from echo commands.

    Disable backslash interpretation, as the ASCII codes are embedded in the color definitions. Also removes empty string, a blank line is already the default output.

  • Declare a function if logic is reused at least twice.

    Created functions warn, die, is_installed and is_file.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Changes Made

  • .editorconfig
  • .gitignore
  • core/setup_mcp.sh
  • hive/scripts/test-mcp-curl.sh
  • scripts/setup.sh

Testing

Describe the tests you ran to verify your changes:

  • Unit tests pass (npm run test)
  • Lint passes (npm run lint)
  • Manual testing performed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@RichardTang-Aden
Copy link
Collaborator

RichardTang-Aden commented Jan 23, 2026

Can you resolve the merge conflict and remove the setup from hive/scripts/test-mcp-curl.sh? The rest of the changes look good to me

@hanggrian hanggrian closed this Jan 23, 2026
@hanggrian hanggrian force-pushed the refractor/shell-scripts-lint branch from dedfaa7 to cfba965 Compare January 23, 2026 23:14
@hanggrian
Copy link
Author

Hi Richard! Thanks for reviewing my code. A new pull request has been made to address the recent changes in the main branch: #161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants