Skip to content

Implement Coletor Fiscal v3.2 SaaS-ready architecture#10

Open
ademirrodrigo wants to merge 8 commits intomainfrom
codex/create-coletor-fiscal-v3.2-saas-ready-system
Open

Implement Coletor Fiscal v3.2 SaaS-ready architecture#10
ademirrodrigo wants to merge 8 commits intomainfrom
codex/create-coletor-fiscal-v3.2-saas-ready-system

Conversation

@ademirrodrigo
Copy link
Owner

Summary

  • replace the legacy monitoring codebase with the Coletor Fiscal v3.2 SaaS-ready backend structured around SQLAlchemy models and modular collectors
  • add a Streamlit dashboard with login, company management and collection orchestration hooks prepared for SEFAZ integrations
  • document installation and deployment with environment samples, automation scripts, and nginx reverse proxy guidance

Testing

  • python -m compileall app web

https://chatgpt.com/codex/tasks/task_e_6900d155dee88329a267792bed0f790b

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


from .config import settings

engine = create_engine(settings.database_url, connect_args={"check_same_thread": False})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make database engine creation SQLite-aware

The new persistence layer unconditionally passes connect_args={"check_same_thread": False} when creating the SQLAlchemy engine. That option is only valid for SQLite drivers; if DATABASE_URL points to PostgreSQL or another backend (which the SaaS‑ready architecture is supposed to support), SQLAlchemy will raise TypeError: Invalid argument(s) 'check_same_thread' sent to create_engine and the app fails during import. Wrap the argument so it is only supplied when the URL uses SQLite, otherwise omit it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant