Upgrade admob #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please note, these changes are not backwards compatible. The exported view properties now match the properties of the DFPBannerView. I've now implemented the `validAdSizes` property, and replaced the `testDeviceID` property with `testDevices`. Also the simulator device id can be specified using `PublisherBanner.simulatorId` instead of `"EMULATOR"`. The conversion of json to GADAdSize is now implemented using a RCTConvert category. And lastly, the `loadBanner` method is now exposed to react, to allow easy banner refresh, and removes the need of checking which properties are available before making a request to admob.
this omits the need of explicit conversion
also, there are no nativeOnly events so removed those
instead of the mixed names like RNAdMobManager and BannerView they're all named like the implemented class, e.g. RNGADBannerView and RNGADBannerViewManager.
replaced deprecated RCTEventDispatcher with RCTEventEmitter
replaced deprecated RCTEventDispatcher with RCTEventEmitter
this is more or less the bare minimum, we should probably add some rules along the way
the adUnitID can only be set once, and sometimes in unfortunate rerenders the prop is set twice, which caused a crash.
…React Native 0.47.0
since app events are a DFP feature, and not an AdMob feature
- replace markdown tables with html, to make them more maintainable - reformat prop definitions - increment all headings - move badge - explicit react-native link - reorder event table columns - version disclaimer
add adFailedToOpen and videoStarted events
Moving forward: Version 2 beta.
* alpha => beta * remove linking specifics since there are no anomalies we can simply refer to the default linking guide if that might not be sufficient we can always opt for an additional wiki page dedicated to linking the library
since events are not scoped to a module they did clash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.