Avoid MITM attacks by verifying download integrity#3
Open
alromh87 wants to merge 3 commits intoadamthesax:masterfrom
Open
Avoid MITM attacks by verifying download integrity#3alromh87 wants to merge 3 commits intoadamthesax:masterfrom
alromh87 wants to merge 3 commits intoadamthesax:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceutable files downloaded trough http: are vulnerable to MiM attacks, since server can be faked and file with dangerous code executed, ideally https should be implemented on the server but in this case, file is not available through https so download is verified with sha512
If incorrect file is downloaded hash will be different and installation fail
File downloads and verifies correctly