Fix for crashes caused on some larger screens#13
Open
ghost wants to merge 2 commits intoadamstyrc:masterfrom
Open
Fix for crashes caused on some larger screens#13ghost wants to merge 2 commits intoadamstyrc:masterfrom
ghost wants to merge 2 commits intoadamstyrc:masterfrom
Conversation
… which would cause a crash on cropping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some devices the check for whether or not the drag put the cropper outside the image would fail, allowing it to move beyond the image edge. This would cause a hard crash. I rewrote the logic on that page and it no longer allows it to leave the image.