FEATURE: Localization fallbacks (server-side) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FallbackLocaleList object tells I18n::Backend::Fallbacks what order the languages should be attempted in. Because of the translate_accelerator patch, the SiteSetting.default_locale is *not* guaranteed to be fully loaded after the server starts, so a call to ensure_loaded! is added after the locale is set for the current user. The declarations of config.i18n.fallbacks = true in the environment files were actually garbage, because the I18n.default_locale was SiteSetting.default_locale, so there was nothing to fall back to. *derp*
adamsaimi
commented
Oct 25, 2025
| # user locale, site locale, english | ||
| # TODO - this can be extended to be per-language for a better user experience | ||
| # (e.g. fallback zh_TW to zh_CN / vice versa) | ||
| [locale, SiteSetting.default_locale.to_sym, :en].uniq.compact |
Owner
Author
There was a problem hiding this comment.
[Security] Path Traversal in I18n.locale
- Problem: User-controlled
I18n.localeis used in locale loading without sanitization, risking arbitrary file reads via path traversal. - Fix: Strictly validate and sanitize
I18n.localeto allow only valid identifiers, preventing path traversal attacks.
adamsaimi
commented
Oct 25, 2025
| end | ||
| end | ||
|
|
||
| def ensure_loaded!(locale) |
Owner
Author
There was a problem hiding this comment.
[Refactor] Intrusive Monkey-Patching of I18n Backend
- Problem: The
ensure_loaded!method is added toI18n::Backend::Simplevia a freedom patch, leading to fragility and potential conflicts. - Fix: Re-evaluate the need for monkey-patching; consider alternative, less intrusive ways to extend
I18nfunctionality or encapsulate the behavior.
adamsaimi
commented
Oct 25, 2025
| # user locale, site locale, english | ||
| # TODO - this can be extended to be per-language for a better user experience | ||
| # (e.g. fallback zh_TW to zh_CN / vice versa) | ||
| [locale, SiteSetting.default_locale.to_sym, :en].uniq.compact |
Owner
Author
There was a problem hiding this comment.
[Refactor] Tight Coupling in I18n Fallback Logic
- Problem: The
FallbackLocaleListdirectly accessesSiteSetting.default_locale, tightly coupling the I18n fallback mechanism to a specific application configuration. - Fix: Decouple
FallbackLocaleListfromSiteSetting.default_localeby injecting the default locale or using a more generic configuration access pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 9