Skip to content

Comments

Upgrade to NUKE 10#28

Merged
adams85 merged 2 commits intoadams85:masterfrom
lahma:nuke-10.1
Dec 26, 2025
Merged

Upgrade to NUKE 10#28
adams85 merged 2 commits intoadams85:masterfrom
lahma:nuke-10.1

Conversation

@lahma
Copy link
Collaborator

@lahma lahma commented Dec 26, 2025

The NET 10 tests are not passing for me locally of on GitHub Actions. The Release mode stack size test needs to go down to 395 like the Debug one. I think it's unrelated for this but very confusing. Also 4 parsing tests are failing after that. @adams85 are you experiencing any problems locally?

I earlier notified you on wrong PR, sorry for that.

@lahma lahma marked this pull request as ready for review December 26, 2025 08:48
@adams85
Copy link
Owner

adams85 commented Dec 26, 2025

The NET 10 tests are not passing for me locally of on GitHub Actions. The Release mode stack size test needs to go down to 395 like the Debug one. I think it's unrelated for this but very confusing.

Yep, I can confirm that this is unrelated to NUKE.

Looks like .NET 10 has brought some massive degradation in terms of stack space handling. I guess this is related to stack-allocated reference types.

Anyway, I don't think we can do anything but bite the bullet and lower the recursion depth. Based on my tests, 650 is still fine for release mode on Windows.

Also 4 parsing tests are failing after that.

Which tests are those? I don't have any other failing tests in my local dev env.

BTW, as for NUKE in general, do you know about this: nuke-build/nuke#1564 (comment) ?

For security and reputational reasons, I do not intend to transfer the repository to a successor maintainer. The community is free to fork it under their own name and on their own schedule.

This sounds pretty concerning. What do you think about the future of NUKE? In light of this announcement, is it worth staying on this train in your opinion?

@lahma
Copy link
Collaborator Author

lahma commented Dec 26, 2025

The NET 10 tests are not passing for me locally of on GitHub Actions. The Release mode stack size test needs to go down to 395 like the Debug one. I think it's unrelated for this but very confusing.

Yep, I can confirm that this is unrelated to NUKE.

Looks like .NET 10 has brought some massive degradation in terms of stack space handling. I guess this is related to stack-allocated reference types.

Hmm, interesting. That probably would explain this new behavior, even though surprising.

Anyway, I don't think we can do anything but bite the bullet and lower the recursion depth. Based on my tests, 650 is still fine for release mode on Windows.

Also 4 parsing tests are failing after that.

Which tests are those? I don't have any other failing tests in my local dev env.

This was my bad, I have automatic EOL cleanup on in Rider and this caused the output to be different for the test case as returned value did not have trailing whitespace.

BTW, as for NUKE in general, do you know about this: nuke-build/nuke#1564 (comment) ?

For security and reputational reasons, I do not intend to transfer the repository to a successor maintainer. The community is free to fork it under their own name and on their own schedule.

This sounds pretty concerning. What do you think about the future of NUKE? In light of this announcement, is it worth staying on this train in your opinion?

I'm aware of the situation, the latest 10.1.0 enabled most of the new NET 10 scenarios like slnx format etc so I'm not too concerned. NUKE is a mature project which allows you to work around things if needed. For me it's still the go-to choice until/if any blockers arise.

@adams85
Copy link
Owner

adams85 commented Dec 26, 2025

Well, then I think we're good to go. Thanks for the update!

@adams85 adams85 merged commit 035af7c into adams85:master Dec 26, 2025
3 checks passed
@lahma lahma deleted the nuke-10.1 branch December 26, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants