Revert incorrect code signing workflow environment name change#8
Revert incorrect code signing workflow environment name change#8
Conversation
…ing' Co-authored-by: adamgell <27519+adamgell@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the code signing workflow that was causing 403 Forbidden errors during release signing. The workflow was referencing a non-existent GitHub environment name (codesigning), preventing access to the Azure Trusted Signing secrets stored in the actual signing environment.
Changes:
- Corrected the GitHub Actions environment name from
codesigningtosigningin the code signing workflow
|
@copilot the environment codesigning is correct. I have all the env there. |
Co-authored-by: adamgell <27519+adamgell@users.noreply.github.com>
You're correct - I've reverted the change back to The 403 Forbidden error from Azure Trusted Signing suggests the issue is Azure-side permissions rather than the GitHub environment name. The service principal may need permissions on the Azure Trusted Signing resource, or the certificate profile configuration may need adjustment. |
|
@copilot What permissions do I need to assign the app registration |
For Azure Trusted Signing, assign the "Trusted Signing Certificate Profile Signer" role to your service principal (app registration). This is the minimum required permission for signing operations. To assign the role:
Via Azure CLI: az role assignment create \
--assignee <service-principal-object-id> \
--role "Trusted Signing Certificate Profile Signer" \
--scope "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.CodeSigning/codeSigningAccounts/<account-name>/certificateProfiles/<profile-name>"Assigning at the certificate profile level follows least privilege principles. This should resolve the 403 Forbidden error. |
The code signing workflow was failing with 403 Forbidden when attempting to sign binaries. Initial analysis incorrectly identified the environment name as the issue, but the repository owner confirmed that
codesigningis the correct environment name where all Azure Trusted Signing secrets are configured.Changes
.github/workflows/codesign.ymlto useenvironment: codesigning(the correct configured environment)Note
The 403 Forbidden error from Azure Trusted Signing is an authentication/authorization issue on the Azure service side, not related to the GitHub environment name. Potential causes include:
Reference: https://github.com/adamgell/IntuneGUI/actions/runs/22119061592/job/63934507307#step:9:1
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.