Add support for custom annotations in missing Deployment templates#656
Open
leandrorusso wants to merge 1 commit intoacryldata:masterfrom
Open
Add support for custom annotations in missing Deployment templates#656leandrorusso wants to merge 1 commit intoacryldata:masterfrom
leandrorusso wants to merge 1 commit intoacryldata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom
annotationsin specific Deployment templates where this capability was previously missing.When using this Helm chart as a dependency within a custom Helm chart, there is a need to orchestrate the deployment order of certain components. This can be achieved either through:
helm.sh/hook)argocd.argoproj.io/sync-wave)While most components in the chart already support custom annotations, this functionality was not available in the following Deployment templates:
charts/datahub/subcharts/acryl-datahub-actions/templates/deployment.yamlcharts/datahub/subcharts/datahub-frontend/templates/deployment.yamlcharts/datahub/subcharts/datahub-gms/templates/deployment.yamlThis PR introduces annotation support in these three Deployments to ensure consistency across all components and enable advanced orchestration use cases.
Changes
Added support for configurable custom annotations in:
acryl-datahub-actionsDeploymentdatahub-frontendDeploymentdatahub-gmsDeploymentAligned behavior with other components that already expose annotation configuration.
Motivation
Including this chart as a dependency in higher-level Helm charts may require fine-grained orchestration of resource creation. Enabling custom annotations allows users to:
Testing
values.yaml.Note
Low Risk
Low risk Helm templating change that only adds optional Deployment-level annotations. Main risk is unintended rollout/order effects if users supply hook/sync-wave annotations incorrectly.
Overview
Adds an
annotationsvalues field to theacryl-datahub-actions,datahub-frontend, anddatahub-gmssubcharts and wires it into each component’sDeploymentmetadata.annotations.This enables users to apply Deployment-level orchestration annotations (e.g., Helm hooks or Argo CD sync waves) consistently across these previously-missing templates, without changing behavior when
annotationsis empty.Written by Cursor Bugbot for commit 0979dbd. This will update automatically on new commits. Configure here.