Skip to content

Add support for custom annotations in missing Deployment templates#656

Open
leandrorusso wants to merge 1 commit intoacryldata:masterfrom
vyxel-io:feat/dev-annotations
Open

Add support for custom annotations in missing Deployment templates#656
leandrorusso wants to merge 1 commit intoacryldata:masterfrom
vyxel-io:feat/dev-annotations

Conversation

@leandrorusso
Copy link

@leandrorusso leandrorusso commented Feb 16, 2026

Description

This PR adds support for custom annotations in specific Deployment templates where this capability was previously missing.

When using this Helm chart as a dependency within a custom Helm chart, there is a need to orchestrate the deployment order of certain components. This can be achieved either through:

  • Helm hooks (e.g., helm.sh/hook)
  • Argo CD sync waves (e.g., argocd.argoproj.io/sync-wave)

While most components in the chart already support custom annotations, this functionality was not available in the following Deployment templates:

  • charts/datahub/subcharts/acryl-datahub-actions/templates/deployment.yaml
  • charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
  • charts/datahub/subcharts/datahub-gms/templates/deployment.yaml

This PR introduces annotation support in these three Deployments to ensure consistency across all components and enable advanced orchestration use cases.


Changes

  • Added support for configurable custom annotations in:

    • acryl-datahub-actions Deployment
    • datahub-frontend Deployment
    • datahub-gms Deployment
  • Aligned behavior with other components that already expose annotation configuration.


Motivation

Including this chart as a dependency in higher-level Helm charts may require fine-grained orchestration of resource creation. Enabling custom annotations allows users to:

  • Control resource lifecycle using Helm hooks
  • Define deployment ordering using Argo CD sync waves
  • Maintain consistency across all DataHub components

Testing

  • Verified that annotations are correctly rendered when specified in values.yaml.
  • Confirmed no changes in behavior when annotations are not provided.

Note

Low Risk
Low risk Helm templating change that only adds optional Deployment-level annotations. Main risk is unintended rollout/order effects if users supply hook/sync-wave annotations incorrectly.

Overview
Adds an annotations values field to the acryl-datahub-actions, datahub-frontend, and datahub-gms subcharts and wires it into each component’s Deployment metadata.annotations.

This enables users to apply Deployment-level orchestration annotations (e.g., Helm hooks or Argo CD sync waves) consistently across these previously-missing templates, without changing behavior when annotations is empty.

Written by Cursor Bugbot for commit 0979dbd. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments