Skip to content

feat: ignore tpl_testing#183

Merged
j-d-carmichael merged 3 commits intomainfrom
feature/ignore_tpl_testing
Mar 4, 2025
Merged

feat: ignore tpl_testing#183
j-d-carmichael merged 3 commits intomainfrom
feature/ignore_tpl_testing

Conversation

@j-d-carmichael
Copy link
Copy Markdown
Contributor

@j-d-carmichael j-d-carmichael commented Mar 4, 2025

https://github.com/j-d-carmichael/gen-it-ts-esm-server

There are now too many libs that only offer ESM making it impossible to use the og - I have got an ESM server template running on vitest but in the process wanted a space in a template to test...

https://github.com/j-d-carmichael/gen-it-ts-esm-server/tree/main/_tpl_testing_

With this pr when gen-it finds "tpl_testing" it will not copy it over. This allows the dev of the tpl to build and test a full server before pushing changes to git.

Naming up for debate...

@j-d-carmichael
Copy link
Copy Markdown
Contributor Author

@p-mcgowan I updated the gh workflow actions, node versions etc -> merged that back into this branch to get the tests working again.

The code-coverage step was not working so removed for now, we can add back in later.. but it complained about something in latest code from code-cov

Comment thread docs/_pages/templates.md Outdated

### Testing template files

Generate-it will ignore any files in a folder called "". An example can be found in the https://github.com/j-d-carmichael/gen-it-ts-esm-server template.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder called "" - is this supposed to be "_tpl_testing_"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might have to escape it like \_tpl\_testing\_

@p-mcgowan
Copy link
Copy Markdown
Contributor

lgtm - just the docs need an update (i think)
is it possible to pass in ignores? i can't remember - if so, the naming doesn't matter but either way _tpl_testing_ is fine

Comment thread CHANGELOG.md
# Changelog

### 5.62.0 04/03/2025
feat: _tpl_testing_ added to the default ignore allowing a tpl to hold own test files
Copy link
Copy Markdown
Contributor

@p-mcgowan p-mcgowan Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: \_tpl_testing_ will prevent it from being italic (just looking at the "rich diff" option in github
image

@j-d-carmichael
Copy link
Copy Markdown
Contributor Author

lgtm - just the docs need an update (i think) is it possible to pass in ignores? i can't remember - if so, the naming doesn't matter but either way tpl_testing is fine

you can via the nodegenrc file

separate topic but i think after this wonderful ESM journey... deno land is the next stop for me.

Cool will get the doc issue resolve and released - cheers

@j-d-carmichael j-d-carmichael merged commit 5d9202c into main Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants