Skip to content

CPD-13207: Add a retry of 60m for release download. #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rutuja810 wants to merge 1 commit into
base: proxy-cli-hook-aws-v3
Choose a base branch
from
+9 −4
Open

CPD-13207: Add a retry of 60m for release download. #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/moonshot/artifact_repository/s3_bucket_via_github_releases.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,18 @@ def upload_to_s3(file, key)
#
# @param version [String] Version to be downloaded
# @param [String] Build file downloaded.
# @raise [RuntimeError] If the file fails to download correctly after 3
# attempts.
# @raise [RuntimeError] If the file fails to download correctly within 60 minutes.
def download_from_github(version)
file_pattern = "*#{version}*.tar.gz"
attempts = 0

Retriable.retriable on: RuntimeError do
retry_opts = {
tries: 360, # up to 360 x 10s = 60 minutes
max_elapsed_time: 60 * 60, # 60 minutes
base_interval: 10,
multiplier: 1 # constant interval, no exponential backoff
}

Retriable.retriable(on: RuntimeError, **retry_opts) do
# Make sure the directory is empty before downloading the release.
FileUtils.rm(Dir.glob('*'))

Expand Down