Set wizard-specific variables for all values#3
Open
schonarth wants to merge 3 commits intoacornejo:masterfrom
Open
Set wizard-specific variables for all values#3schonarth wants to merge 3 commits intoacornejo:masterfrom
schonarth wants to merge 3 commits intoacornejo:masterfrom
Conversation
Replaced all hard-coded values and direct Bootstrap dependencies with wizard-specific variables, allowing for easy overriding when needed. If the variables aren't touched, the output remains the same. Also added a border property, none by default, which can also be overridden if necessary.
Separated border and border-color properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced all hard-coded values and direct Bootstrap dependencies with wizard-specific variables, allowing for easy overriding when needed.
If the variables aren't touched, the output remains the same. If the Bootstrap variables are changed, the output is changed accordingly.
Also added a border property, none by default, which can also be overridden if necessary.
I used these changes to override the wizard's appearance from outside the wizard's .less file. Super practical!