Skip to content

Fix events CLI huh forms#176

Merged
GaballaGit merged 10 commits intomainfrom
feat/events-cli
Mar 20, 2026
Merged

Fix events CLI huh forms#176
GaballaGit merged 10 commits intomainfrom
feat/events-cli

Conversation

@TheJolman
Copy link
Collaborator

closes #151

@TheJolman TheJolman requested a review from GaballaGit as a code owner March 10, 2026 19:33
@TheJolman TheJolman marked this pull request as draft March 10, 2026 19:33
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

godoc reference preview ready ✨
Go Documentation

@TheJolman TheJolman marked this pull request as ready for review March 10, 2026 19:38
@TheJolman TheJolman requested a review from Copilot March 12, 2026 19:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the events CLI subcommand flow so commands like acmcsuf-cli events get execute directly instead of dropping into an interactive menu, aligning behavior with the pre-“huh forms” CLI.

Changes:

  • Replaces the interactive events menu with a standard events root command and direct subcommands.
  • Refactors events CRUD commands to use the shared internal/cli/client request helper + JSON pretty-printing.
  • Splits time-related helpers out of the removed utils/cli_helper.go into utils/time.go.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
internal/cli/root.go Adds a global /health connectivity check in PersistentPreRunE.
internal/cli/client/client.go Adds CheckConnection helper for health checks.
internal/cli/events/root.go Introduces a proper events root command and attaches subcommands.
internal/cli/events/get.go Simplifies get to run directly (optional --id).
internal/cli/events/delete.go Simplifies delete to require --id and run directly.
internal/cli/events/post.go Reworks post to use a huh form + shared HTTP client helper.
internal/cli/events/put.go Reworks put to require --id, fetch old payload, and submit updates via shared client helper.
internal/cli/events/events.go Removes the old interactive menu implementation.
utils/cli_helper.go Deletes the old CLI helper grab-bag file (printing/forms/connection/etc).
utils/time.go Adds time formatting + duration-to-end-time helper (moved from deleted helper file).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@GaballaGit GaballaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approoooovvvvveeeeeee, very awesome work

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@GaballaGit GaballaGit merged commit da2bbd1 into main Mar 20, 2026
2 checks passed
@GaballaGit GaballaGit deleted the feat/events-cli branch March 20, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command line subcommands broken after huh forms merged

3 participants