Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the events CLI subcommand flow so commands like acmcsuf-cli events get execute directly instead of dropping into an interactive menu, aligning behavior with the pre-“huh forms” CLI.
Changes:
- Replaces the interactive
eventsmenu with a standardeventsroot command and direct subcommands. - Refactors
eventsCRUD commands to use the sharedinternal/cli/clientrequest helper + JSON pretty-printing. - Splits time-related helpers out of the removed
utils/cli_helper.gointoutils/time.go.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
internal/cli/root.go |
Adds a global /health connectivity check in PersistentPreRunE. |
internal/cli/client/client.go |
Adds CheckConnection helper for health checks. |
internal/cli/events/root.go |
Introduces a proper events root command and attaches subcommands. |
internal/cli/events/get.go |
Simplifies get to run directly (optional --id). |
internal/cli/events/delete.go |
Simplifies delete to require --id and run directly. |
internal/cli/events/post.go |
Reworks post to use a huh form + shared HTTP client helper. |
internal/cli/events/put.go |
Reworks put to require --id, fetch old payload, and submit updates via shared client helper. |
internal/cli/events/events.go |
Removes the old interactive menu implementation. |
utils/cli_helper.go |
Deletes the old CLI helper grab-bag file (printing/forms/connection/etc). |
utils/time.go |
Adds time formatting + duration-to-end-time helper (moved from deleted helper file). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GaballaGit
approved these changes
Mar 20, 2026
Member
GaballaGit
left a comment
There was a problem hiding this comment.
approoooovvvvveeeeeee, very awesome work
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #151