Implemented permanent AWS storage for Genuary#1151
Draft
Conversation
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
EthanThatOneKid
left a comment
There was a problem hiding this comment.
I haven't tested the code locally myself, however at first glance the code is well-written and looks good to me.
Collaborator
|
if a feature like this ever gets merged we should probably use Cloudflare R2 (10 GB included in free tier) |
Collaborator
Author
|
I am not planning to keep working on that since it's been over a year, but anyone is free to take over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a module
s3handler.jsto handle uploading and deleting files from S3 bucket.Created a helper function
downloadFileto download pinned items to a temp folder on a runner in order to upload it to S3Updated
getMediaFromPinsfunction to download and upload each pin, and append the resulting permanent link to the output.Updated
update_genuaryworkflow to install dependencies and include env variables.This obviously won't work immediately, because a new AWS S3 bucket with proper permissions needs to be set up first, and credentials fed to the CI/CD pipeline.
Required env variables: