feat/2025-07-31-push-message #26
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ackkerman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new feature that allows users to provide a custom commit message when performing a gh sync push operation. This message is then propagated to the underlying git subtree push command, enhancing the clarity and traceability of subtree synchronization commits.
Highlights
- New Feature: Push Message Support: The
pushcommand now supports a-mor--messageflag, allowing users to specify a custom commit message when pushing subtree changes back to the remote repository. - Core Logic Enhancement: The
subtree_pushfunction insrc/gitops.rshas been updated to accept an optional message, which is then passed directly to the underlyinggit subtree pushcommand. - Documentation Updates: Both
README.mdanddocs/About.mdhave been updated to reflect the new-moption for thepushcommand, including usage examples. - New Test Case: A new integration test (
push_with_custom_message) has been added intests/cli.rsto verify that the custom message is correctly handled and passed to thegit subtree pushcommand.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for a custom commit message to the push command using the -m/--message flag. The changes include updates to the CLI definition, command handling, and git operations logic. The documentation in README.md and docs/About.md has been updated, and a new test case verifies the functionality. The test suite could benefit from refactoring to reduce duplicated setup logic.
| fn push_with_custom_message() { | ||
| let repo = setup_repo(); | ||
| let git_shim = fake_git_path(&repo); | ||
|
|
||
| let (path_env, orig_path) = path_vars(&git_shim); | ||
|
|
||
| Command::cargo_bin("gh-sync") | ||
| .unwrap() | ||
| .current_dir(repo.path()) | ||
| .env("PATH", &path_env) | ||
| .env("ORIG_PATH", &orig_path) | ||
| .args(&["connect", "app", "git@github.com:a/b.gitt"]) | ||
| .assert() | ||
| .success(); | ||
|
|
||
| Command::cargo_bin("gh-sync") | ||
| .unwrap() | ||
| .current_dir(repo.path()) | ||
| .env("PATH", &path_env) | ||
| .env("ORIG_PATH", &orig_path) | ||
| .args(&["push", "app", "-m", "custom"]) | ||
| .assert() | ||
| .success() | ||
| .stdout(predicate::str::contains("-m custom")); | ||
| } |
There was a problem hiding this comment.
The test push_with_custom_message and others (pull_with_custom_message, pull_falls_back_to_add, remove_mapping) share duplicated setup logic (repo creation, git shim setup, env vars, connect command).
Consider refactoring this common setup into a helper function or test fixture to improve maintainability and make the tests more focused. This reduces boilerplate and makes the tests easier to understand and modify.
Summary
-m/--messageforpushgit subtree push-moptionTesting
cargo testhttps://chatgpt.com/codex/tasks/task_e_688b05ebb40c8330a62916d39593aa82