Skip to content

Make binding attribute optional #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make binding attribute optional #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dhcp_leases/dhcpleases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def __init__(self, ip, properties, options=None, sets=None, now=None):
self.data = properties
self.options = options
self.sets = sets
_, self.binding_state = properties['binding'].split(' ', 1)
self.binding_state = properties['binding'].split(' ', 1)[1] if 'binding' in properties else None
self._now = now

@property
Expand Down
7 changes: 7 additions & 0 deletions dhcp_leases/test_lease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ def test_init_no_starts_property(self):
self.assertFalse(lease.active)
self.assertEqual(lease.binding_state, 'free')

def test_init_no_binding(self):
self.lease_data.pop('binding')
lease = Lease("192.168.0.1", self.lease_data)
self.assertEqual(lease.ip, "192.168.0.1")
self.assertIsNone(lease.binding_state)
self.assertFalse(lease.active)

@freeze_time("2015-07-6 8:15:0")
def test_valid_no_starts_property(self):
self.lease_data.pop('starts')
Expand Down