Feature request - support black/white#1
Draft
travisdahl wants to merge 1 commit intoachudars:masterfrom
Draft
Conversation
First off, thank you so much for updating this plugin, definitely seems worth updating! I am using your fork. More of a feature request than an issue but I find it strange that if I upload a logo that is black or white that neither are included in the palette? Maybe it could be an optional param or something? Vurrent;y I am just manually adding them to the array but I like how your plugin kind of prioritizes the colors, and having them in the correct priority would help (me in my situation at least)
✅ Deploy Preview for color-thief-palette ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
Can you add a few sample files or screenshots of the problem @travisdahl ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the PR but there is no issues tab and I couldn't find a good way to contact you.
First off, thank you so much for updating this plugin, definitely seems worth updating! I am using your fork. Not sure if you
are open to feature requests but
More of a feature request than an issue but I find it strange that if I upload a logo that has black or white that neither are included in the palette? Maybe it could be an optional param or something
includeBW? Currently I am just manually adding them to the array but I like how your plugin kind of prioritizes the colors, and having them in the correct priority would help (me in my situation at least)Knowing which color is the background color would be useful too. I am analyzing logos and trying to pic the background color if they have them or know if its transparent (png).
Maybe these usecases are too specific, but if you see nay value, let me know