Add const specifier for not changed strings.#16
Open
tobbad wants to merge 1 commit intoachimdoebler:masterfrom
Open
Add const specifier for not changed strings.#16tobbad wants to merge 1 commit intoachimdoebler:masterfrom
tobbad wants to merge 1 commit intoachimdoebler:masterfrom
Conversation
|
Good stuff. Const modifiers are always useful wherever you can put them. I've messaged Achim before, he hasnt abandoned the project, just University. Ill merge this into my branch when I get infront of a PC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to integrate uGui into micropython when I saw these small issues. In my opinion a string which is not modified in the receiving function should be declared as const. This is as well needed by the function which call the ugui function where I receive a
const char *. Further there are some small fixes which satisfy a picky gcc. I have a little bit problem with this latin-1 encoded file in eclipse and some fixes below show, that others had it, too. Why not just use the regular ASCII set?