Common - Add setting for compass magnetic declination#9761
Merged
PabstMirror merged 10 commits intomasterfrom Dec 15, 2024
Merged
Common - Add setting for compass magnetic declination#9761PabstMirror merged 10 commits intomasterfrom
PabstMirror merged 10 commits intomasterfrom
Conversation
PabstMirror
changed the title
jonpas
changed the title
johnb432
reviewed
Oct 12, 2024
johnb432
approved these changes
Oct 12, 2024
Contributor
johnb432
left a comment
johnb432
left a comment
There was a problem hiding this comment.
Out of curiosity, which year's dataset did you use? I saw 2 PRs trying to update the values to 2020 (cmweiss/geomag#15), would be neat to use those if you don't already use them.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Contributor
Author
|
IIRC I used that python lib with an updated WMM.COF |
johnb432
approved these changes
Dec 15, 2024
Contributor
|
Imo push this out for 3.18.2 and we can update the data later if deemed necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref map https://www.ncei.noaa.gov/sites/default/files/2022-02/Miller%20Projection%20Main%20Field-%20Annual%20Change%20Declination%20%28D%29.jpg