Missile Guidance - Fix attack profile and laser code variable

[tbeswick96]

When merged this pull request will:

• Use proper source for attack profile and laser code (both set on vehicle, currently retrieved from player)
• Don't use E variant macros inside laser for own variables and functions
• Check list of remote targets for the locked target as one of the fallbacks for hellfire ARH onFired, to enable firing on datalink track files without needing LOS on the target or radar sensor on
  • If target is a remote track, the missile isn't set as active off the rail so it doesn't go maddog

[PabstMirror]

think about FFV guy shooting javelin, you want to use the shooter of the missle (themself), not vehicle player (the car)
ref https://github.com/acemod/ACE3/blob/master/addons/missileguidance/functions/fnc_cycleAttackProfileKeyDown.sqf#L28-L35
it uses CBA_fnc_canUseWeapon

[tbeswick96]

Ah damn, hadn't considered that case, will make an edit later today to factor it in

[tbeswick96]

@PabstMirror Does that look correct now? Uses the same logic as the laser and attack profile source

[PabstMirror]

Do you have an example where _configurationSource will be different from _shooter
This even will be triggered from the object that fired the missile
edit: _shooter is arg0, not the newish arg7

[tbeswick96]

I will try to get a vanilla repro this evening, but I was testing with an Apache, where the hellfires are launched by the gunner.
For months until I investigated and made this change, my pilot guys had hellfires never track the laser if the laser wasn't the default code. I enabled tracing and found that the laser was being set on the player object rather than the vehicle.

ACE3/addons/laser/functions/fnc_keyLaserCodeChange.sqf

Line 62 in 6299428

_currentShooter setVariable [QGVAR(code), _newLaserCode, true];

[TheCandianVendingMachine]

Does this work with

ACE3/addons/laser/functions/fnc_showVehicleHud.sqf

Line 102 in e2ac18a

private _vehicleLockMode = _vehicle getVariable [QEGVAR(missileguidance,attackProfile), _defaultAttackProfile];

? I am worried about this breaking something somewhere else unintentionally, I think this was assumed to be the vehicle from the get-go