Skip to content

Maps - Add topographic map item#7625

Draft
PabstMirror wants to merge 2 commits intomasterfrom
topographicMaps
Draft

Maps - Add topographic map item#7625
PabstMirror wants to merge 2 commits intomasterfrom
topographicMaps

Conversation

@PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Apr 6, 2020

Adds a simple topo map that doesn't magically show every single building, wall, rock and tree

New:
20200405185251_1

Old (sat tex off):
20200405185242_1

Creates a new map ctrl over the old one
this breaks anything that uses drawEH on the old map (dspCtrl 51)
ace already has decent support for non "itemMap"

TODO?

  • probably re-add hill numbers
  • maybe show urban areas with some kind of shading (scripted?)

@PabstMirror PabstMirror added this to the Ongoing milestone Apr 6, 2020
@PabstMirror
Copy link
Contributor Author

So this got a lot more complex than I thought, most of the diff is just moving code over to a new helper: ace_common_fnc_addMapEventHandler for adding events to maps

  • proper save/load support (markers/maptool did not support)
  • runs events on the correct map, since there may be more than one now

markers, maptools, gestures, flashlight effects all seem to work correctly
the only bug right now is vanilla line drawing does not work on the new map

@jonpas
Copy link
Member

jonpas commented Sep 11, 2023

the only bug right now is vanilla line drawing does not work on the new map

Could add a note in a corner or something that drawing is not supported?

@jonpas jonpas added status/WIP kind/feature Release Notes: **ADDED:** labels Sep 11, 2023
@veteran29
Copy link
Member

Could add a note in a corner or something that drawing is not supported?

It could be re-implemented with "new" commands that allow creating polylines.

@BrettMayson BrettMayson changed the title WIP: Maps - Add topographic map item Maps - Add topographic map item Oct 16, 2023
@BrettMayson BrettMayson marked this pull request as draft October 16, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Release Notes: **ADDED:** status/WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants