Skip to content

Sandbag - Refactor#11278

Open
johnb432 wants to merge 4 commits intomasterfrom
sandbag-refactor
Open

Sandbag - Refactor#11278
johnb432 wants to merge 4 commits intomasterfrom
sandbag-refactor

Conversation

@johnb432
Copy link
Contributor

@johnb432 johnb432 commented Feb 3, 2026

When merged this pull request will:

  • Title.
    • Code cleanup.
      • Removed unused code.
      • Consolidated multiple similar functions into one.
    • Readded/fixed carrying not working on sandbags.
      • Init EH was present, but didn't do anything, because carrying attribute wasn't present.
      • Init EH for dragging wasn't necessary, as dragging component already covers Thing and ThingX.
      • Only added carrying, as dragging adds extra interaction, which can make interactions quite cluttered imo.
    • Add more controls for placing sandbags.
      • Adjust height and distance, in addition to the existing rotation.
      • Added machine-translated translations.
    • Stop placing sandbag if camera changes (featureCamera EH).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Feb 3, 2026
@johnb432 johnb432 marked this pull request as ready for review February 7, 2026 09:47

// Change height
if (CBA_events_alt) exitWith {
GVAR(deployHeight) = 1.5 min (-1.5 max GVAR(deployHeight) + (_scroll * 0.1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could get ace_sandbag_deployHeight to -1.98

Suggested change
GVAR(deployHeight) = 1.5 min (-1.5 max GVAR(deployHeight) + (_scroll * 0.1));
GVAR(deployHeight) = 1.5 min (-1.5 max (GVAR(deployHeight) + (_scroll * 0.1)));

};

// Change distance
GVAR(deployDistance) = 1.5 min (0.36 max GVAR(deployDistance) + (_scroll * 0.1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GVAR(deployDistance) = 1.5 min (0.36 max GVAR(deployDistance) + (_scroll * 0.1));
GVAR(deployDistance) = 1.5 min (0.36 max (GVAR(deployDistance) + (_scroll * 0.1)));

@PabstMirror PabstMirror added this to the 3.20.3 milestone Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants