Wardrobe - Add more directional properties#11226
Merged
BrettMayson merged 27 commits intoacemod:masterfrom Feb 8, 2026
Merged
Conversation
Contributor
Author
PabstMirror
reviewed
Jan 11, 2026
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
reviewed
Jan 12, 2026
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
…com/OverlordZorn/ACE3 into wardrobe-add-direcitonal-attributes
This was referenced Jan 12, 2026
OverlordZorn
added a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jan 12, 2026
OverlordZorn
added a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jan 12, 2026
OverlordZorn
added a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jan 12, 2026
PabstMirror
reviewed
Jan 12, 2026
| case ( | ||
| isClass (configFile >> QUOTE(ADDON) >> _classOrigin >> "modifiableTo" >> _classTarget >> "directionalActionName") | ||
| ): { | ||
| getText (configFile >> QUOTE(ADDON) >> _classOrigin >> "modifiableTo" >> _classTarget >> "directionalActionName") |
Contributor
There was a problem hiding this comment.
I don't think this is needed, but we could add warnings for old configs
Suggested change
| getText (configFile >> QUOTE(ADDON) >> _classOrigin >> "modifiableTo" >> _classTarget >> "directionalActionName") | |
| WARNING_2("using old directionalActionName instead of displayName on %1->%2",_classOrigin,_classTarget ); | |
| getText (configFile >> QUOTE(ADDON) >> _classOrigin >> "modifiableTo" >> _classTarget >> "directionalActionName") |
Contributor
Author
There was a problem hiding this comment.
The warning is a good idea, but maybe it should be script running on mission start / gamestart that checks all laoded configs and puts a list in the RPT?
Contributor
Author
There was a problem hiding this comment.
I added a warning on preStart which itterates over all classes and checks for depricated properties.
RPT output:
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'sound_timing'. use 'soundTiming' instead: 'G_Bandanna_aviator'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'sound_timing'. use 'soundTiming' instead: 'G_EyeProtectors_F'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'sound_timing'. use 'soundTiming' instead: 'G_EyeProtectors_Earpiece_F'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'sound_timing'. use 'soundTiming' instead: 'G_WirelessEarpiece_F'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'directionalActionName'. use 'displayName' instead: 'ace_wardrobe_base' >> 'modifiableTo' >> 'test1'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'directionalActionName'. use 'displayName' instead: 'ace_wardrobe_base' >> 'modifiableTo' >> 'test2'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'directionalActionName'. use 'displayName' instead: 'ace_wardrobe_base_U_sleeves_up' >> 'modifiableTo' >> 'test1'
3:17:03 [ACE] (wardrobe) WARNING: depricated property 'directionalActionName'. use 'displayName' instead: 'ace_wardrobe_base_U_sleeves_up' >> 'modifiableTo' >> 'test2'
Contributor
Author
There was a problem hiding this comment.
@PabstMirror lmk if you#re happ with this solution or if you want me to make this dev script instead of a fnc.
PabstMirror
approved these changes
Jan 12, 2026
Contributor
Author
|
hurrdurr, not ready to merge. im checking properties with |
PabstMirror
pushed a commit
that referenced
this pull request
Jan 17, 2026
PabstMirror
pushed a commit
that referenced
this pull request
Jan 17, 2026
PabstMirror
pushed a commit
that referenced
this pull request
Jan 17, 2026
…citonal-attributes
PabstMirror
approved these changes
Feb 1, 2026
2 tasks
BrettMayson
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Does:
Add support for directional properties:
Renames existing properties while providing legacy support
Furthermore