Medical Treatment - Add Numerical Pulse setting#10452
Merged
LinkIsGrim merged 9 commits intoacemod:masterfrom Nov 6, 2024
Merged
Medical Treatment - Add Numerical Pulse setting#10452LinkIsGrim merged 9 commits intoacemod:masterfrom
LinkIsGrim merged 9 commits intoacemod:masterfrom
Conversation
Contributor
Author
|
Personally think "Advanced Pulse" may be misleading name but couldn't think of anything better that fit with the other settings |
Member
|
"Numerical Pulse" instead could work. |
Contributor
Author
|
Agreed, will change once I am able to get to a computer unless anyone would like to contrib |
Member
|
I think it should be a dropdown with |
Contributor
|
If I ever finish #7740 : I don't see any conflicts with this, and setting is already list type so I should be able to just add another variant |
SpicyBagpipes
changed the title
Contributor
Author
|
Implemented suggested changes from vet & mike, nothing more from me |
johnb432
reviewed
Nov 3, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
approved these changes
Nov 5, 2024
LinkIsGrim
reviewed
Nov 5, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.