feat: add focused clip range slicing#687
Open
ChuxiJ wants to merge 1 commit intofeat/v0.1.1-clip-surface-uxfrom
Open
feat: add focused clip range slicing#687ChuxiJ wants to merge 1 commit intofeat/v0.1.1-clip-surface-uxfrom
ChuxiJ wants to merge 1 commit intofeat/v0.1.1-clip-surface-uxfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sliceClipToRangeto the project store for focused clip isolationLinked Issues
Verification
npx vitest run src/store/__tests__/sliceClipToRange.test.ts tests/unit/clipRangeSlice.test.tsx tests/unit/clipBlockHover.test.tsx tests/unit/clipResizeAndFadeVisuals.test.tsx tests/unit/clipResizeModifiers.test.tsx tests/unit/clipScissorMode.test.tsx tests/unit/clipWaveform.test.tsxnpx tsc --noEmitnpm run buildhttp://127.0.0.1:4173/verifying body drag slices the focused clip into 3 segments and header drag still moves the selected segmentNotes
This PR is stacked on top of #686. Review this diff against
feat/v0.1.1-clip-surface-ux.