fix: capture repaint settings in AutoGen batch parameter snapshot#922
fix: capture repaint settings in AutoGen batch parameter snapshot#922ChuxiJ merged 1 commit intoace-step:mainfrom
Conversation
capture_current_params() and _build_capture_current_params_inputs() were missing repaint_mode and repaint_strength, causing AutoGen batches to silently fall back to defaults instead of using the user's settings. Completes the fix started in ace-step#877. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes add capture support for two repaint UI parameters— Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
repaint_modeandrepaint_strengthin the AutoGen batch parameter snapshot so background generation uses the user's actual settings instead of silently falling back to defaultsProblem
PR #816 added
repaint_modeandrepaint_strengthas required parameters togenerate_with_progress()and wired them into the foreground generation path. The batch/AutoGen path was not updated —capture_current_params()never captured these values, and_build_capture_current_params_inputs()never passed the UI components.PR #877 fixed the resulting crash by adding
.get()fallbacks with defaults ingenerate_next_batch_background(), but the parameter capture itself was still missing. The result: AutoGen batches always generate with"balanced"mode at strength0.5regardless of what the user selects in the UI. No error, no crash — just silently ignored settings.Fix
Added
repaint_modeandrepaint_strengthto two functions that were missed during the #816 wiring:capture_current_params()inbatch_queue.py— added to function signature and return dict so the snapshot includes the user's repaint settings_build_capture_current_params_inputs()ingeneration_batch_navigation_wiring.py— added the two UI components to the Gradio input list so their values are passed to the capture functionTotal change is 6 lines of production code across 2 files. Follows the exact same pattern as every other parameter in both functions.
Completes the fix started in #877.
Platform impact
Test plan
test_repaint_params_included_in_capture— non-default values (aggressive, 0.8) round-trip through capturetest_repaint_params_default_values_captured— default values (balanced, 0.5) round-trip through capturetest_capture_clears_audio_codes— existing behavior preserved (audio codes cleared for fresh AutoGen content)test_capture_forces_random_seed— existing behavior preserved (random seed forced for variation)batch_queue_test.py,batch_management_background_test.py, anddecomposition_contract_generation_test.pypassSummary by CodeRabbit
New Features
Tests