Skip to content

tests: updated test for aggregated paths#749

Open
nyrahul wants to merge 3 commits intoaccuknox:devfrom
nyrahul:dev
Open

tests: updated test for aggregated paths#749
nyrahul wants to merge 3 commits intoaccuknox:devfrom
nyrahul:dev

Conversation

@nyrahul
Copy link
Contributor

@nyrahul nyrahul commented Jun 21, 2023

Purpose of PR?:

Test aggrgation logic

Does this PR introduce a breaking change?
No

Checklist:

  • New feature (non-breaking change which adds functionality)
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

nyrahul and others added 2 commits June 21, 2023 08:10
Signed-off-by: Rahul Jadhav <nyrahul@gmail.com>
Signed-off-by: Vishnu Soman <vishnu@accuknox.com>

if assert.NotEmpty(t, paths) {
results := AggregatePaths(paths)
if assert.NotEmpty(t, results) {
Copy link
Contributor Author

@nyrahul nyrahul Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add specific asserts for all 9 results? @vishnusomank

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @nyrahul

Signed-off-by: Vishnu Soman <vishnu@accuknox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants