Profile picture dropdown menu front end (not functional)#26
Profile picture dropdown menu front end (not functional)#26
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Use Django URL template tag ▹ view | ✅ Fix detected |
 |
Empty href in My Profile link ▹ view | ✅ Fix detected |
 |
Unnecessary DOM query at page load ▹ view | ✅ Fix detected |
|
Move inline JavaScript to external file ▹ view | ✅ Fix detected |
 |
Improve dropdown menu documentation ▹ view | ✅ Fix detected |
 |
Inline JavaScript Handler ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| resumax_backend/resumax_algo/templates/resumax_algo/index.html | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| <h3>{{ user.username }}</h3> | ||
| </div> | ||
| <hr> | ||
| <a href="" class="sub-menu-link"> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| let subMenu= document.getElementById("subMenu"); | ||
|
|
||
| function toggleMenu(){ | ||
| subMenu.classList.toggle("open-menu"); | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <p>{{ user.username }}</p> | ||
| <div class="user-section"> | ||
| <p>{{ user.username }}</p> | ||
| <!--Profile Picture drop down menu--> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <script> | ||
| let subMenu= document.getElementById("subMenu"); | ||
|
|
||
| function toggleMenu(){ | ||
| subMenu.classList.toggle("open-menu"); | ||
| } | ||
| </script> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <p>My Profile</p> | ||
| <span>></span> | ||
| </a> | ||
| <a href="http://127.0.0.1:8000/auth/login/" class="sub-menu-link"> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <!--Profile Picture drop down menu--> | ||
| <img src="{% static 'images/profile-pic.png' %}" class="user-picture" onclick="toggleMenu()"> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Pull Request Test Coverage Report for Build 18635170695Details
💛 - Coveralls |
slageyuri
left a comment
slageyuri
left a comment
There was a problem hiding this comment.
changes on unnecessary lines, and making the code more clear
|
Corrections on Korbit review made |
2 participants
Added profile picture to the nav-bar + drop down menu when you click on the profile picture. It has 2 options, "My Profile" and "Logout". Logout take you to the login page, but My Profile is not functional yet.
Description by Korbit AI
What change is being made?
Add a profile picture to the top navbar with a dropdown menu containing user info and links (My Profile, Logout), along with a lightweight JavaScript toggle to show/hide the submenu.
Why are these changes being made?
Provide a front-end UI for user profile actions and prepare for authentication wiring; the dropdown is currently non-functional beyond UI toggle and static links.