Minor Prompt changes (system_instructions)#21
Merged
ndayiemile merged 2 commits intomainfrom Sep 28, 2025
Merged
Conversation
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Inconsistent XML Formatting ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| resumax_backend/resumax_algo/system_instructions.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+14
to
+17
| <initial_instruction> | ||
| <rule>Upon receiving a user's document, the primary goal is to provide an overall review first, followed by improvement tips and recommended changes if needed.</rule> | ||
| <rule> The review must assess clarity, conciseness, relevance, impact and fit to the student's specific career goals .</rule> | ||
| </initial_instruction> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
There was a problem hiding this comment.
Great work! Work on these minor Korbit-AI suggestions, then I will approve your PR
Pull Request Test Coverage Report for Build 18069273354Details
💛 - Coveralls |
ndayiemile
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made identity more restrict, so the agent persona can be define in the very beginning with information like tone, expertise etc, and then his functionality/rules are in a separate from his personality.
Minor word change in some rules
I think that having a initial instruction sector to reinforce the agent's function would benefit to avoid hallucinations and focusing more in its job, could lead to improvement.
Description by Korbit AI
What change is being made?
Implement minor prompt improvements to system_instructions:
Why are these changes being made?
Enhance clarity and usefulness of the assistant's reviews by emphasizing draft-level outputs, structured evaluation criteria, and a more constructive tone, aligning responses with student ownership and standard practices from reference documents. No behavioral or policy changes beyond presentation and guidance for drafts.