Open
Conversation
- Changed deprecated event bus register/unregister. - Fixed (partially) the fill task to not pre-generating world (now generates but SpongeForge MUST NOT be installed). - Fixed the crash caused by fill/trim.
|
at least you tried to fix it. :-) I give credit where it is well deserved. I'll test it on my test server with todays forge/sponge builds and see how it goes. Thanks! -Steve Edit: I was going to download the jar but looks like it isn't posted yet. Once it is, I'll test it out. |
Owner
|
I appreciate you're attempt to fix it! The reason however is persisting from me using Access Transformers to get and add to a private list from the world class, with the server not detecting the AT's thus refusing the existence of the public field. I could however easily end up fixing it by using some reflection, the problem is currently time on my hands has been very tight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix the
fillcommand and achieved something. Now it fills the world, but SpongeForge causes odd phenomenoms.Also fixed couple of crashes and cleaned some warnings.
Tries to fix #1, #2 and #3.
I honestly have no idea what I'm doing.