Skip to content

[fixes #70] Wrong Color in GeoNode menu#13

Open
abulojoshua1 wants to merge 1 commit intomasterfrom
issue_70_wrong_color_in_geonode
Open

[fixes #70] Wrong Color in GeoNode menu#13
abulojoshua1 wants to merge 1 commit intomasterfrom
issue_70_wrong_color_in_geonode

Conversation

@abulojoshua1
Copy link
Owner

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@abulojoshua1 abulojoshua1 force-pushed the issue_70_wrong_color_in_geonode branch from 99c01a7 to 90a3b47 Compare September 2, 2020 15:47
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #13 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   58.97%   58.49%   -0.49%     
==========================================
  Files         184      184              
  Lines       20567    20567              
  Branches     3415     3415              
==========================================
- Hits        12130    12031      -99     
- Misses       7363     7458      +95     
- Partials     1074     1078       +4     

Copy link
Collaborator

@afabiani afabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abulojoshua1 I noticed the issue happens only on page details templates, therefore it is probably caused by something odd happening on those templates only.

I don't like this solution, it looks a workaround that might impact negatively other sections of GeoNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants