Scraping Project added #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiju
reviewed
Sep 23, 2021
Fiju
left a comment
Fiju
left a comment
There was a problem hiding this comment.
- Include package.json file in the project and add required scripts in it.
- Constants like base url or any other hard coded value can be maintained as an environment variable. And use those values in the project
- Declare all constants using
constkeyword rather themletorvar - Add build script in package.json that will bundle our code
scrapper.cjs
Outdated
| } | ||
| }; | ||
|
|
||
| fetchPrada(); |
There was a problem hiding this comment.
We can use IIFE (immediately invoked functional expression) in such cases.
(function() {
.
.
.
})()```
|
|
||
| fetchPrada = async () => { | ||
| try { | ||
| let productsRecord = { totalProducts: 0 }; |
There was a problem hiding this comment.
Always declare immutable variable using const keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.