Skip to content

Add Unizen staking contract#243

Open
minapham17 wants to merge 3 commits intoabridged:masterfrom
minapham17:master
Open

Add Unizen staking contract#243
minapham17 wants to merge 3 commits intoabridged:masterfrom
minapham17:master

Conversation

@minapham17
Copy link

Add Unizen staking contract on Polygon network

Signed-off-by: minapham17 <mina@unizen.io>
@alokt
Copy link
Contributor

alokt commented Jul 2, 2024

@minapham17 can you please resolve conflicts?

@minapham17
Copy link
Author

@alokt conflict resolved. thank you

@alokt
Copy link
Contributor

alokt commented Jul 2, 2024

@minapham17 is it working locally? because test case is failing. can you please check
https://github.com/abridged/collabland-staking-contracts/actions/runs/9755711957/job/26946306312?pr=243

Signed-off-by: minapham17 <mina@unizen.io>
@minapham17
Copy link
Author

@alokt I fixed the issue, and now the test should work. During the testing process, I noticed something important:

For the same static call to our contract, it seems that the RPC is not very stable during the test. This means it can succeed at one moment but fail a few seconds later if I run the test again.

To handle this, I added a try-catch block to prevent failed tests due to the RPC status. Thank you for your review and please let me know if I need to change anything.

@minapham17
Copy link
Author

@alokt just reminder in case you missed my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants