Updates for code base targeting Python 3.9#293
Conversation
.github/workflows/ci.yml
Outdated
| - "3.x" # newest Python that is stable | ||
| - "3.14" |
There was a problem hiding this comment.
Unrelated, these are the same until October. Might make more sense to just leave one of them, or use an intermediate value + 3.x.
There was a problem hiding this comment.
Thanks @henryiii for the review, I will modify that.
henryiii
left a comment
There was a problem hiding this comment.
Don't know why the CI (Cirrus, I think) is stuck in queue.
|
|
||
| [testenv:typecheck] | ||
| base_python = 3.8 | ||
| base_python = 3.9 |
There was a problem hiding this comment.
There was a problem hiding this comment.
That's to keep the pip install installing libraries that still support this Python. It's more important if you keep support for EoL Pythons, or use scientific libraries that follow SPEC 0. This also happens with typeshed at some point after EoL.
If it works, feel free to remove, we can always re-add if it's a problem. I think we are closer to EoL now so it might be fine.
There was a problem hiding this comment.
I see that makes sense and makes things more reliable...
Would we retain some of these gains if we replace base_python with setting PIP_PYTHON_VERSION=3.9 as environment variable inside tox.ini?
(I understand that this may not be fully reliable because some packages may be available for 3.9 but not work on 3.13 for example)
There was a problem hiding this comment.
I see, apparently we cannot:
ERROR: Can not use any platform or abi specific options unless installing via '--target' or using '--dry-run'So let's leave it like this for now.
Thanks @henryiii
Includes automatic updates from Ruff