Show warning for folder uploads + clarify docs #2022
+69
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdollahShahid
force-pushed
the
fix-folder-upload-message
branch
from
918a270 to
6a93b00
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience around folder uploads by adding a client-side warning when folders are dropped into the upload area and documenting that folders are not supported.
- Added folder detection in the drag-and-drop handler with a warning notification
- Updated documentation to explicitly state that folders/directories cannot be uploaded
- Applied code formatting improvements (arrow functions, consistent quotes)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scancodeio/static/add-inputs.js |
Detects dropped folders using the File System API and displays a warning message; includes code formatting improvements |
docs/inputs.rst |
Adds a note explaining that folders are not supported and users should upload archives instead |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Muhammad Abdullah Shahid <108458621+abdollahShahid@users.noreply.github.com>
Signed-off-by: Muhammad Abdullah Shahid <108458621+abdollahShahid@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Muhammad Abdullah Shahid <108458621+abdollahShahid@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Muhammad Abdullah Shahid <108458621+abdollahShahid@users.noreply.github.com>
abdollahShahid
force-pushed
the
fix-folder-upload-message
branch
from
4f057c9 to
1433bff
Compare
Author
|
All commits are signed-off (DCO ✅). Waiting for workflow approvals / CI to complete. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR clarifies that uploading folders/directories is not supported and improves UX by showing a warning when a user drops a folder into the upload area.
Changes:
docs/inputs.rstexplaining that directories are not supported and archives should be uploaded instead.add-inputs.jsand display a warning message suggesting uploading a.zipor.tar.gz.Why:
Dragging and dropping a folder currently appears to hang or does nothing, which is confusing. This provides immediate feedback and points users to the supported approach.
How tested:
Fixes #573