Skip to content

Fix scan_for_virus crash when CodebaseResource is missing #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adityakk9031 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix scan_for_virus crash when CodebaseResource is missing #2020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scanpipe/pipes/clamav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from pathlib import Path

from django.conf import settings
from django.core.exceptions import ObjectDoesNotExist

import clamd

Expand All @@ -47,7 +48,19 @@ def scan_for_virus(project):
status, reason = results
resource_path = Path(resource_location).relative_to(project.codebase_path)

resource = project.codebaseresources.get(path=resource_path)
try:
resource = project.codebaseresources.get(path=str(resource_path))
except ObjectDoesNotExist:
project.add_error(
description="CodebaseResource not found for ClamAV result",
model="ScanForVirus",
details={
"resource_location": resource_location,
"resource_path": str(resource_path),
},
)
continue

virus_report = {
"calmav": {
"status": status,
Expand Down