Fix #4583: Add rule for CKSource Holding copyright #4649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaushik-Kumar-CEG
force-pushed
the
fix-4583-ckeditor-false-positive
branch
from
307da02 to
52561be
Compare
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
Kaushik-Kumar-CEG
force-pushed
the
fix-4583-ckeditor-false-positive
branch
from
52561be to
2ff5c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4583
Description
Adds a specific detection rule for "CKSource Holding" copyright headers found in CKEditor 5 (specifically augmentation.d.ts).
The Problem
ScanCode currently detects these headers as a complex mix of GPL/LGPL/MPL because they trigger a generic "CKSource" rule.
The Solution
Added a new rule (cksource-holding_1.RULE) that matches the exact copyright text and licensing pointer.
Matches: "Copyright (c) 2003-2023, CKSource Holding sp. z o.o. ... For licensing, see LICENSE.md..."
Result: Correctly detects gpl-2.0-plus OR commercial-license.
Tasks
[x] Reviewed contribution guidelines
[x] PR is descriptively titled 📑 and links the original issue above 🔗
[] Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
[x] Commits are in uniquely-named feature branch and has no merge conflicts 📁
[ ] Updated documentation pages (if applicable)
[ ] Updated CHANGELOG.rst (if applicable)