This repository was archived by the owner on Feb 12, 2021. It is now read-only.
Add python-dev in the installation docs #111 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singh1114
suggested changes
Jan 31, 2018
README.md
Outdated
| Python.org downloads since Python 2.7.9) | ||
|
|
||
| - Install PostgreSQL 9.5.x of later. (9.6 preferred) | ||
| On Debian distros use: `sudo apt-get install postgresql-9.5-dev` |
Collaborator
There was a problem hiding this comment.
On Ubuntu 16.04: This statement gives me the error:
Unable to locate package postgresql-9.5-dev
You can change it postgresql-9.5
Signed-off-by: Tushar Mittal <chiragmittal.mittal@gmail.com>
techytushar
force-pushed
the
Documentation
branch
from
84e74ab to
e505213
Compare
singh1114
approved these changes
Feb 6, 2018
Author
|
@pombredanne please review.. |
Member
|
One ping is enough ;) |
pombredanne
reviewed
Feb 9, 2018
|
|
||
| - Install PostgreSQL 9.5.x of later. (9.6 preferred) | ||
| On Debian distros use: `sudo apt-get install postgresql-9.5-dev` | ||
| On Debian distros use: `sudo apt-get install postgresql-9.5` |
Member
There was a problem hiding this comment.
I think we need postgres dev or else compiling psycopg will fail.
Author
There was a problem hiding this comment.
I searched for postgresql, but did not find any package with the name postgresql-9.5-dev. Also for installing postgresql we need to add the repository url, so should we add this to the docs too?
pombredanne
reviewed
Feb 9, 2018
| On Debian distros use: `sudo apt-get install postgresql-9.5` | ||
|
|
||
| - Install extra utilities if needed: `sudo apt-get install wget build-essential redis-server` | ||
| - Install extra utilities if needed: `sudo apt-get install wget build-essential redis-server python-dev` |
Member
There was a problem hiding this comment.
I think these are not extra but always required
Author
|
sorry did that comment by mistake 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #111
Signed-off-by: Tushar Mittal chiragmittal.mittal@gmail.com