Condition synchronous snapshotting on hot_standby_feedback being enabled #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification to #2 , which gates the logic on whether or not hot_standby_feedback is enabled. This article gives a good overview on what the feature does https://www.cybertec-postgresql.com/en/what-hot_standby_feedback-in-postgresql-really-does/ .
The only reliable way to run queries for >30seconds is to set hot_standby_feedback. This isn't turned on by default to prevent bloat on the primary, so we check for its presence before using pg_export_snapshot.
I refactored the logic to make it a bit easier to grok