Skip to content

Conversation

@mattheworiordan
Copy link
Member

@mattheworiordan mattheworiordan commented Jan 12, 2026

The CookieMessage component was used for the classic cookie consent banner on the Ably website. The website now exclusively uses OneTrust for cookie consent management, making this component unused.

Companion change: https://github.com/ably/website/pull/7679


This was discovered during local development when I saw the old cookie banner pop up, which was confusing. Turns out we added OneTrust years ago, but never removed the old code.

Summary by CodeRabbit

  • Chores
    • Removed the cookie consent notification feature and related styling from the application.

✏️ Tip: You can customize this high-level summary in your review settings.

The CookieMessage component was used for the classic cookie consent
banner on the Ably website. The website now exclusively uses OneTrust
for cookie consent management, making this component unused.

Companion change: ably/website#chore/remove-classic-cookie-consent
@mattheworiordan mattheworiordan marked this pull request as ready for review January 12, 2026 06:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

Walkthrough

The CookieMessage component and all its associated files have been removed from the codebase, including the React component, Storybook story, CSS styling, and stylesheet imports.

Changes

Cohort / File(s) Change Summary
CookieMessage Component Removal
src/core/CookieMessage.tsx, src/core/CookieMessage/CookieMessage.stories.tsx, src/core/CookieMessage/component.css
Deleted entire CookieMessage component (57 lines), its Storybook story file (12 lines), and associated CSS styling (15 lines) that previously managed cookie consent UI with close animation and persistence.
Stylesheet Import Cleanup
.storybook/styles.css
Removed import reference to CookieMessage component CSS.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A cookie component hops away,
Its message and style gone for the day,
No more consent pop-ups in sight,
The interface feels wonderfully light! 🍪✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides clear motivation (OneTrust now used exclusively) and context, but does not follow the repository's template structure with required sections like testing steps and checklists. Add the missing template sections including 'How do you manually test this?' and complete the 'Merge/Deploy Checklist' and 'Frontend Checklist' with appropriate selections or notes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removal of the legacy CookieMessage component, which is the primary focus of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a60d358 and e858abf.

📒 Files selected for processing (4)
  • .storybook/styles.css
  • src/core/CookieMessage.tsx
  • src/core/CookieMessage/CookieMessage.stories.tsx
  • src/core/CookieMessage/component.css
💤 Files with no reviewable changes (4)
  • src/core/CookieMessage.tsx
  • src/core/CookieMessage/component.css
  • src/core/CookieMessage/CookieMessage.stories.tsx
  • .storybook/styles.css

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants