Skip to content

Conversation

@VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Jan 7, 2026

We changed the name of the build file in #2133 but forgot to update the CDN deploy script to reference the new name.

Resolves AIT-242

Summary by CodeRabbit

  • Documentation

    • Updated migration guide with UMD bundle filename changes (objects.umd.js → liveobjects.umd.js)
    • Updated global variable name documentation (AblyObjectsPlugin → AblyLiveObjectsPlugin)
  • Chores

    • Updated CDN deployment configuration to reflect bundle naming changes

✏️ Tip: You can customize this high-level summary in your review settings.

We changed the name of the build file in #2133
but forgot to update the CDN deploy script to reference the new name.

Resolves AIT-242
@VeskeR VeskeR requested a review from mschristensen January 7, 2026 11:59
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Walkthrough

The changes address a CDN deployment issue by updating documentation and build scripts to reference the renamed UMD bundle file from objects.umd.js to liveobjects.umd.js, along with the corresponding global variable name change.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/migration-guides/v2/liveobjects.md
Expanded UMD bundle migration notes with explicit changes: bundle filename objects.umd.jsliveobjects.umd.js, global variable AblyObjectsPluginAblyLiveObjectsPlugin. Retained existing API entrypoint migration note.
Build Script Configuration
scripts/cdn_deploy.js
Updated file filtering regex pattern from objects.umd to liveobjects.umd to match the renamed bundle filename for CDN deployment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A bundle renamed, the CDN awaits,
From objects to liveobjects—what fate!
The plugin now sparkles with a new name,
AblyLiveObjectsPlugin, much better the same,
Deploy scripts adjusted, all ready to play!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the CDN deploy script to reference the renamed LiveObjects plugin build file.
Linked Issues check ✅ Passed The PR fulfills all requirements from AIT-242: updates the CDN deploy script from objects.umd to liveobjects.umd and documents the new CDN link in the migration guide.
Out of Scope Changes check ✅ Passed All changes are directly related to AIT-242 requirements: updating the CDN deploy script and migration documentation for the renamed LiveObjects plugin.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AIT-242/fix-liveobjects-cdn

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ed0f0de and ac4ef6b.

📒 Files selected for processing (2)
  • docs/migration-guides/v2/liveobjects.md
  • scripts/cdn_deploy.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: test-node (18.x)
  • GitHub Check: test-node (16.x)
  • GitHub Check: test-npm-package
  • GitHub Check: test-node (20.x)
  • GitHub Check: test-browser (webkit)
  • GitHub Check: test-browser (firefox)
  • GitHub Check: test-browser (chromium)
🔇 Additional comments (2)
docs/migration-guides/v2/liveobjects.md (1)

79-82: Excellent documentation of the UMD bundle changes!

The added note clearly documents the breaking changes for users consuming the library via <script> tags, including both the filename change and the global variable rename. This will help users migrate smoothly.

scripts/cdn_deploy.js (1)

24-24: Regex update correctly reflects the build file rename.

The change from objects.umd to liveobjects.umd in the fileRegex is correct and complete. Verification confirms no remaining references to objects.umd exist in the codebase, and the build system outputs (liveobjects.umd.js and liveobjects.umd.min.js) match the updated regex pattern.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VeskeR VeskeR merged commit eef8ed2 into main Jan 7, 2026
21 of 26 checks passed
@VeskeR VeskeR deleted the AIT-242/fix-liveobjects-cdn branch January 7, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants